From: Cindy Zhang <cindyzyx9@gmail.com>
Date: Fri, 12 Feb 2016 03:22:43 +0000 (-0800)
Subject: add todo's after reviewing code with danny
X-Git-Url: http://challenge-bot.com/repos/?a=commitdiff_plain;h=287263e6c51e1d5c273458d04749a01a95b7bd49;p=3501%2Fstronghold-2016

add todo's after reviewing code with danny
---

diff --git a/notes/cindy.org b/notes/cindy.org
new file mode 100644
index 00000000..66155f7a
--- /dev/null
+++ b/notes/cindy.org
@@ -0,0 +1,14 @@
+* todo
+  * figure out where the frame perimeter starts, and where the arm is mounted
+    relative to that
+  * find out actual arm and hand length, as well as the height at which the arm
+    is mounted
+  * change arm and hand to "armHorizontal/armVertical" and "handHorizontal/
+    handVertical"
+  * change method "getArmHorizontalDist" to "getArmHorizontalDisplacement"
+  * change method "getArmHeight" to "getArmVerticalDisplacement"
+  * for getArmHorizontalDisplacement figure out if measurements are all in 
+    inches
+* doing
+  * code review
+* done
\ No newline at end of file
diff --git a/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java b/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java
index a762c90f..324ad204 100755
--- a/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java
+++ b/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java
@@ -118,6 +118,7 @@ public class DefenseArm extends Subsystem {
     defenseHand.set(speed);
   }
 
+  // TODO: figure out if measurements are all in inches
   public double getArmHorizontalDist() {
     double arm = Constants.DefenseArm.ARM_LENGTH * Math.cos(getArmPotAngle());
     double hand = Constants.DefenseArm.HAND_LENGTH