From 669451502e414a323e1be3ae72a490fae00cc0c7 Mon Sep 17 00:00:00 2001 From: Rohan Rodrigues Date: Sat, 4 Mar 2017 11:30:38 -0800 Subject: [PATCH] Remove getters for shift pistons --- .../robot/commands/driving/ToggleGear.java | 9 ++------ .../shooter/RunIndexWheelContinuous.java | 5 +++-- .../team3501/robot/subsystems/DriveTrain.java | 21 +++++++------------ 3 files changed, 12 insertions(+), 23 deletions(-) diff --git a/src/org/usfirst/frc/team3501/robot/commands/driving/ToggleGear.java b/src/org/usfirst/frc/team3501/robot/commands/driving/ToggleGear.java index 3a17440..ca802e7 100644 --- a/src/org/usfirst/frc/team3501/robot/commands/driving/ToggleGear.java +++ b/src/org/usfirst/frc/team3501/robot/commands/driving/ToggleGear.java @@ -31,16 +31,11 @@ public class ToggleGear extends Command { Value rightGearPistonValue = driveTrain.getRightGearPistonValue(); if (leftGearPistonValue == Constants.DriveTrain.LOW_GEAR) { - driveTrain.setHighGear(driveTrain.getLeftPiston()); + driveTrain.setHighGear(); } else { - driveTrain.setLowGear(driveTrain.getLeftPiston()); + driveTrain.setLowGear(); } - if (rightGearPistonValue == Constants.DriveTrain.LOW_GEAR) { - driveTrain.setHighGear(driveTrain.getRightPiston()); - } else { - driveTrain.setLowGear(driveTrain.getRightPiston()); - } } @Override diff --git a/src/org/usfirst/frc/team3501/robot/commands/shooter/RunIndexWheelContinuous.java b/src/org/usfirst/frc/team3501/robot/commands/shooter/RunIndexWheelContinuous.java index 932e845..ab46b3f 100644 --- a/src/org/usfirst/frc/team3501/robot/commands/shooter/RunIndexWheelContinuous.java +++ b/src/org/usfirst/frc/team3501/robot/commands/shooter/RunIndexWheelContinuous.java @@ -3,6 +3,7 @@ package org.usfirst.frc.team3501.robot.commands.shooter; import org.usfirst.frc.team3501.robot.Robot; import org.usfirst.frc.team3501.robot.subsystems.Shooter; +import edu.wpi.first.wpilibj.Timer; import edu.wpi.first.wpilibj.command.Command; /** @@ -19,7 +20,7 @@ import edu.wpi.first.wpilibj.command.Command; */ public class RunIndexWheelContinuous extends Command { private Shooter shooter = Robot.getShooter(); - // private Timer t = new Timer(); + private Timer t = new Timer(); /** * See JavaDoc comment in class for details @@ -35,7 +36,7 @@ public class RunIndexWheelContinuous extends Command { // Called just before this Command runs the first time @Override protected void initialize() { - // t.reset(); + t.reset(); } // Called repeatedly when this Command is scheduled to run diff --git a/src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java b/src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java index 328209e..32ec7b2 100644 --- a/src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java +++ b/src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java @@ -165,33 +165,26 @@ public class DriveTrain extends Subsystem { return rightGearPiston.get(); } - public DoubleSolenoid getLeftPiston() { - return this.leftGearPiston; - } - - public DoubleSolenoid getRightPiston() { - return this.rightGearPiston; - } - /* * Changes the ball shift gear assembly to high */ - public void setHighGear(DoubleSolenoid p) { - changeGear(Constants.DriveTrain.HIGH_GEAR, p); + public void setHighGear() { + changeGear(Constants.DriveTrain.HIGH_GEAR); } /* * Changes the ball shift gear assembly to low */ - public void setLowGear(DoubleSolenoid p) { - changeGear(Constants.DriveTrain.LOW_GEAR, p); + public void setLowGear() { + changeGear(Constants.DriveTrain.LOW_GEAR); } /* * Changes the gear to a DoubleSolenoid.Value */ - private void changeGear(DoubleSolenoid.Value gear, DoubleSolenoid piston) { - piston.set(gear); + private void changeGear(DoubleSolenoid.Value gear) { + leftGearPiston.set(gear); + rightGearPiston.set(gear); } @Override -- 2.30.2