From 59a852091c3a0da0ba0a9ea8f034baa86fd64514 Mon Sep 17 00:00:00 2001 From: Cindy Zhang Date: Thu, 11 Feb 2016 19:22:43 -0800 Subject: [PATCH] add todo's after reviewing code with danny --- notes/cindy.org | 14 ++++++++++++++ .../frc/team3501/robot/subsystems/DefenseArm.java | 1 + 2 files changed, 15 insertions(+) create mode 100644 notes/cindy.org diff --git a/notes/cindy.org b/notes/cindy.org new file mode 100644 index 00000000..66155f7a --- /dev/null +++ b/notes/cindy.org @@ -0,0 +1,14 @@ +* todo + * figure out where the frame perimeter starts, and where the arm is mounted + relative to that + * find out actual arm and hand length, as well as the height at which the arm + is mounted + * change arm and hand to "armHorizontal/armVertical" and "handHorizontal/ + handVertical" + * change method "getArmHorizontalDist" to "getArmHorizontalDisplacement" + * change method "getArmHeight" to "getArmVerticalDisplacement" + * for getArmHorizontalDisplacement figure out if measurements are all in + inches +* doing + * code review +* done \ No newline at end of file diff --git a/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java b/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java index 7dfb6dde..6bb409c0 100755 --- a/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java +++ b/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java @@ -95,6 +95,7 @@ public class DefenseArm extends Subsystem { defenseHand.set(speed); } + // TODO: figure out if measurements are all in inches public double getArmHorizontalDist() { double arm = Constants.DefenseArm.ARM_LENGTH * Math.cos(getArmPotAngle()); double hand = Constants.DefenseArm.HAND_LENGTH -- 2.30.2