separate dimensions from form

[challenge-bot] / 3d-printables / sonar-table-top-holder.scad

diff --git a/3d-printables/sonar-table-top-holder.scad b/3d-printables/sonar-table-top-holder.scad
index 8f0d1539d9a9aa6f39172a40759669127db5723f..23279e40736dbab68368ba2076d4f6a0c7e70093 100644 (file)
--- a/3d-printables/sonar-table-top-holder.scad
+++ b/3d-printables/sonar-table-top-holder.scad
@@ -14,34 +14,14 @@
 
 $fn = 60;
 
+include <sonar-table-top-holder-dimensions.scad>
 use <oshw.scad>
 oshw_dy = 120.366;
 oshw_dx = 133.888;
 
-// 3/16 inch in mm deck_depth = 4.7625;
-// 1/4 inch in mm = 6.35
-// subtract a little to be a squeeze fit
-deck_depth = 4.7625 - 0.4;
-// sonar sensor measurements taken with calipers:
-//  10.82 in between, 42.33 outside, 15.82 diameter
-// measured diameter of 15.82 with calipers,
-//  but when printed ends up being too small, so add some
-sonar_diameter = 15.82 + 0.4;
-sonar_radius = sonar_diameter / 2;
-sonar_height = 13.8;
-between_sonar_centers = sonar_diameter + 10.82;
-// the sonar cylinders are placed on the pcb at slightly different positions
-//  from one sensor to the next, so this allows for that variance.
-between_sonar_centers_variance = 2;
-// keep at least this much plastic surrounding the sonar cylinder on all sides
-buffer = 3;
-sonar_holder_length = buffer + between_sonar_centers + sonar_diameter + buffer;
-sonar_holder_width = buffer + sonar_diameter + buffer;
-// sonar_holder_depth is deck_depth minus a little bit to make arm fit
-//  into deck holder
-sonar_holder_depth = deck_depth - 0.7875;
-
-deck_holder_length = sonar_holder_depth * 2 + deck_depth + 15;
+module sonar_holder_2d() {
+  difference() {
+    square([sonar_holder_length, sonar_holder_width]); } }
 
 module sonars(){
   translate([between_sonar_centers / 2, 0, 0]){
@@ -61,10 +41,12 @@ module sonar_holder(){
     cube([sonar_holder_length, sonar_holder_width, sonar_holder_depth]);
     translate([sonar_holder_length / 2, sonar_holder_width / 2, -0.05]){
       sonars();}
-    translate([sonar_holder_length - rounded_corner_radius,
-               sonar_holder_width - rounded_corner_radius,
+    translate([sonar_holder_length,
+               sonar_holder_width,
                0]){
-      corner_rounder(rounded_corner_radius, sonar_holder_depth);}}
+      corner_rounder(rounded_corner_radius,
+                     sonar_holder_depth,
+                     "bottom-right");}}
   translate([sonar_holder_length, 0, 0]){
     cube([elbow_length, deck_depth, sonar_holder_depth]);
     translate([elbow_length, 0, 0]){
@@ -109,16 +91,20 @@ module deck_holder(){
           linear_extrude(height = 0.5)
             oshw();}
 
-module corner_rounder_2d(radius){
+module corner_rounder_2d(radius, corner_name="top-left"){
+  rotate_for_corner = (corner_name == "top-left") ? 0 :
+    ((corner_name == "top-right") ? -90 :
+     ((corner_name == "bottom-left") ? 90 :
+      ((corner_name == "bottom-right") ? 180 :
+       1 / 0)));
+  rotate(rotate_for_corner){
     difference (){
-        square (radius);
-        circle (radius);}}
-
-module corner_rounder(radius, height){
-    linear_extrude(height = height){
-        corner_rounder_2d(radius);}}
+      square(radius);
+      translate([radius, radius]){
+        circle(radius);}}}}
 
-deck_holder();
+module corner_rounder(radius, height, corner_name="top-left"){
+  linear_extrude(height = height){
+    corner_rounder_2d(radius, corner_name);}}
 
-translate([0, sonar_holder_depth * 2 + deck_depth + 2, 0]){
-  sonar_holder();}
+sonar_holder();