review commits between [b378dfe and 8260ae5]

diff --git a/notes/danny.org b/notes/danny.org
index 3cf96384ca8020b3e219d9ba7b21e6500653f97c..9a645e225cb3339db8c4a6be395c87eff093dadd 100644 (file)
--- a/notes/danny.org
+++ b/notes/danny.org
@@ -1,14 +1,83 @@
-* todo
-  * notes directory stuff
+* TODO remove commented code
+  * harel c859a8e
+  * src/org/usfirst/frc/team3501/robot/Robot.java:39
+  * use git to save code, do not use comments to save code
+* TODO remove commented code
+  * harel 5c70678
+  * src/org/usfirst/frc/team3501/robot/commands/auton/ChooseStrategy.java
+  * use git to save code, not comments
+* TODO remove commented code
+  * harel 35e19c5
+  * src/org/usfirst/frc/team3501/robot/Robot.java
+  * // Scheduler.getInstance().add(new TimeDrive(.6, 4));
+  * code should not be saved in a comment, that's what git is for
+  * other than that, this commit is very small, good job!!
+* TODO praise for good job, small commit
+  * harel 902f05c
+  * small commit, easy to review, easy to determine it is correct
+  * eeb6c3d 35e19c5
+* TODO whitespace
+  * harel f53566b
+  * src/org/usfirst/frc/team3501/robot/commands/auton/PassChivalDeFrise.java:9
+  * same with PassDrawBridge
+* TODO rewording suggestion
+  * harel 8d270bb
+  * // Determines if the "front" of the robot has been reversed
+    could be
+    // Determines if the side of the robot is the front
+* TODO long line
+  * harel 116863c
+  * src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java:206
+  * double speed = (-frontLeft.get() + -rearLeft.get() + -frontRi ...
+* TODO split commits into smaller chunks
+  * everyone all of them
+  * it's hard to review realy large commits
+* TODO rename IN and OUT to SLURP and BARF
+  * harel e1f7a74
+  * public static final int IN = 1; -> public static final int SLURP = 1;
+  * just a suggestion
+* TODO add note about why oi is instantiated where it is
+  * harel fab544e
+  * src/org/usfirst/frc/team3501/robot/Robot.java
+  * commit message says new OI() needs to be after subsystems it uses,
+    seems like it'd be a good idea to have a note in the code about it
+    so future coders don't trip on the same bug
+* TODO remove whitespace at end of line
+  * harel a68e434
+  * src/org/usfirst/frc/team3501/robot/subsystems/IntakeArm.java
+* TODO fix long lines
+  * harel, a68e434
+  * src/org/usfirst/frc/team3501/robot/subsystems/IntakeArm.java
+* TODO rename *PORT to *BUTTON where appropriate
+  * harel 571a0e2
+  * src/org/usfirst/frc/team3501/robot/Constants.java
+  "public final static int LEFT_JOYSTICK_TRIGGER_PORT = 1;"
+  should be
+  "public final static int LEFT_JOYSTICK_TRIGGER_BUTTON = 1;"
+* TODO shorten long line
+  * harel 571a0e2
+  * src/org/usfirst/frc/team3501/robot/Constants.java:47
+  * "public static final double INCHES_PER_PULSE" ... goes beyond 80 columns
+* TODO remove whitespace at end of line
+  * harel 571a0e2
+  * src/org/usfirst/frc/team3501/robot/commands/intakearm/StopIntake.java:10
+  * lines 10, 13, 16, 18
+* TODO remove whitespace at end of line
+  * harel 571a0e2
+  * src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java
+  * lines 200, 203, 231, 263, 265, 305, 308
+* TODO shorten long line
+  * harel 571a0e2
+  * src/org/usfirst/frc/team3501/robot/subsystems/DriveTrain.java
+  * line 201, 232, 233
+* TODO notes directory stuff
+  * make examples of notes/name.org files
+  * make notes-explanation to explain motivation
+* TODO document how i got bbb and arduino serial communication done
+* TODO git stuff
+  * make notes about git remote prune
+  * make notes about sharing branch between multiple people
+* DONE notes directory stuff
     * make examples of notes/name.org files
-    * make notes-explanation to explain motivation
-  * document how i got bbb and arduino serial communication done
-  * git stuff
-    * make notes about git remote prune
-    * make notes about sharing branch between multiple people
-* doing
-  * notes directory stuff
-    * make examples of notes/name.org files
-* done
-  * make .gitignore
-  * make formatter so code has higher ratio of meaningful conflicts
+* DONE make .gitignore
+* DONE make formatter so code has higher ratio of meaningful conflicts