add todo's after reviewing code with danny

diff --git a/notes/cindy.org b/notes/cindy.org
new file mode 100644 (file)
index 0000000..66155f7
--- /dev/null
+++ b/notes/cindy.org
@@ -0,0 +1,14 @@
+* todo
+  * figure out where the frame perimeter starts, and where the arm is mounted
+    relative to that
+  * find out actual arm and hand length, as well as the height at which the arm
+    is mounted
+  * change arm and hand to "armHorizontal/armVertical" and "handHorizontal/
+    handVertical"
+  * change method "getArmHorizontalDist" to "getArmHorizontalDisplacement"
+  * change method "getArmHeight" to "getArmVerticalDisplacement"
+  * for getArmHorizontalDisplacement figure out if measurements are all in 
+    inches
+* doing
+  * code review
+* done
\ No newline at end of file

diff --git a/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java b/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java
index 7dfb6ddea4aa203db60ffca82947b01efef1264b..6bb409c052bd1cf3f69a79588ffe2c4593ad9fb8 100755 (executable)
--- a/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java
+++ b/src/org/usfirst/frc/team3501/robot/subsystems/DefenseArm.java
@@ -95,6 +95,7 @@ public class DefenseArm extends Subsystem {
     defenseHand.set(speed);
   }
 
+  // TODO: figure out if measurements are all in inches
   public double getArmHorizontalDist() {
     double arm = Constants.DefenseArm.ARM_LENGTH * Math.cos(getArmPotAngle());
     double hand = Constants.DefenseArm.HAND_LENGTH